-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set 'quicktions' to optional imports
With b11b213 quicktions was added as a mandatory requirement to 'mutwo.core'. This happened after the interal representations of durations were changed from 'floats' to 'fractions': Afterwards the performance of 'mutwo.core' significantly dropped. Follow-up commits further improved the performance by using 'floats' instead of 'fractions' for internal calculations [1]. So the performance could be much more improved by simply using 'floats' instead of 'fractions' for internal calculations than by replacing 'fractions' with 'quicktions'. Furthermore nowadays we plan for version 2.0.0 to actually revert the internal representation of durations to float [2]. Due to these reasons it seems to be better to drop 'quicktions' again as a mandatory requirement: then 'mutwo' has less dependencies, which simplifies the installation and the maintenance (these are very important long-goal terms). The first step to do so is to change the 'mutwo.core' codebase to only optionally import 'quicktions' in case it has been installed. The final drop of the 'quicktions' requirement can be done in version 2.0.0. [1] see for instance fc49bb7 [2] https://github.com/mutwo-org/mutwo.core/blob/7d39b80/ROADMAP.md?plain=1#L4
- Loading branch information
1 parent
d0f2cc2
commit e3ee75a
Showing
3 changed files
with
44 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters