Fix search() for currently provisioned node

[ustuehler]

In order for Chef's search function to find the node which is currently being
provisioned, the .json file that describes it must be part of the sandbox that
gets transferred. Thus #create_node method must be called before #super in
the Kitchen::Provisioner::Nodes#create_sandbox method since Kitchen::Provisioner
::Chef::CommonSandbox#create_sandbox calls prepare(:nodes) which just copies
the current content of test/integration/nodes.

[mwrock]

Thanks for the contribution! However, I'm not seeing the problem. super creates the sandbox and initially populates it but does not copy it. That happens later. Also, if your pr is applied, reconverging a suite after the initial converge raises a premisions error.

When you say "currently provisioned node" do you mean the node itself that is being provisioned and NOT neighboring nodes? I definitely see its own node file in /tmp/kitchen/nodes with the current code base. I'm using test-kitchen 1.4.1.

[ustuehler]

Thanks for your review. I'm also using Test Kitchen 1.4.1. super creates the sandbox, that's right, but it does so by copying whatever is in the test/integration/nodes directory when calling prepare(:nodes):

https://github.com/test-kitchen/test-kitchen/blob/72632ed74fcf945a8cbaf8e817496f118a8056e8/lib/kitchen/provisioner/chef/common_sandbox.rb#L232

So when super returns, the nodes directory in the sandbox is considered "fully prepared". Any file created in test/integration/nodes after that will not be included in the sandbox.

[ustuehler]

Also, if your pr is applied, reconverging a suite after the initial converge raises a premisions error.

I wasn't aware of that, but I will look into it.

[mwrock]

Ah right of coarse. For some reason that error is not reproducing. Will try again on the machine where I was getting the error.

[mwrock]

sorry this took so long. This is released to rubygems in 0.3.2. Thanks!!