Fix: deprecated strftime with IntlDateFormatter #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks! Is this intentionally still a draft? |
|
I'm not really familiar with php, so I assumed there would be things that can be improved. Also, I was rushing a little and did not check what the GitHub draft feature is actually used for. |
mzur
reviewed
Feb 24, 2024
Closed
|
I use it on https://hog-neppendorf.de |
The date and time fields of the data structure are assumed to be stored including the respective timezone. Hence, when creating the Unix timestamp from the fields the timezone must be respected, so the IntlDateFormatter can format the string correctly. Instead of strtotime() it is now using the DateTime constructor with a timezone (from date_default_timezone_get()) as argument. Alternatively, one could store the beginTimestamp directly as DateTime(Immutable) object.
… integers. Getters still give the Unix timestamp for backward compatibility.
rmeister
force-pushed
the
fix-strftime
branch
from
7ebffca
to
2949dd3
Compare
The right timezone seems to be already used implicitly, so it must not be applied additionally.
|
Hey @mzur do you think that this PR is ready to be merged? |
|
@rmeister Does everything work for you now? |
|
Yes, looks good so far :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little band-aid for the deprecation of strftime.