Merge pull request #38 from narthur/get-all

fix baserow pagination
narthur · May 6, 2024 · 2300c93 · 2300c93
2 parents a512c9f + e6b6941
commit 2300c93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/factory.spec.ts b/src/factory.spec.ts
@@ -10,12 +10,14 @@ describe("Factory", () => {
     vi.mocked(client.get)
       .mockResolvedValue({
         data: {
-          results: [],
+          results: [{}],
+          next: null,
         },
       })
       .mockResolvedValueOnce({
         data: {
           results: [{}],
+          next: "the_next_url",
         },
       });
   });

diff --git a/src/factory.ts b/src/factory.ts
@@ -34,8 +34,8 @@ export class Factory {
     options: Record<string, unknown> & { page?: number } = {},
     accumulator: R[] = [],
   ): Promise<R[]> {
-    const { results } = await this.sdk.listRows<R>(tableId, options);
-    if (results.length === 0) {
+    const { results, next } = await this.sdk.listRows<R>(tableId, options);
+    if (!next) {
       return accumulator;
     }
     accumulator.push(...results);