correct number field parsing

narthur · Jun 2, 2024 · ce62c92 · ce62c92
1 parent 6cb0fa1
commit ce62c92
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/codegen/makeGetter.spec.ts b/src/codegen/makeGetter.spec.ts
@@ -1,7 +1,7 @@
 import { describe, it, expect } from "vitest";
-import f from "../test/fixtures/fieldDefinition";
-import { makeGetter } from "./makeGetter";
-import { FieldDefinition } from "..";
+import f from "../test/fixtures/fieldDefinition.js";
+import { makeGetter } from "./makeGetter.js";
+import { FieldDefinition } from "../index.js";
 
 function run(field: Partial<FieldDefinition> = {}): string {
   return makeGetter(f(field), [
@@ -116,6 +116,12 @@ describe("makeGetter", () => {
       },
       `"field_name"`,
     ],
+    [
+      {
+        type: "number",
+      },
+      "parseFloat(String(",
+    ],
   ])("%s => `%s`", (field, expected) => {
     expect(run(field)).toContain(expected);
   });

diff --git a/src/codegen/makeGetter.ts b/src/codegen/makeGetter.ts
@@ -47,7 +47,7 @@ function getBody(field: FieldDefinition, tables: Table[]): string {
   const query = `this.getField<${rawType}>("${field.name}")`;
 
   if (field.type === "number" || field.formula_type === "number") {
-    return `return parseFloat(${query}.toString());`;
+    return `return parseFloat(String(${query}));`;
   }
 
   if (field.type === "single_select") {