improve number-type getters

narthur · Apr 15, 2024 · e85e4e6 · e85e4e6
1 parent a427c7c
commit e85e4e6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/codegen/makeGetter.spec.ts b/src/codegen/makeGetter.spec.ts
@@ -70,6 +70,20 @@ describe("makeGetter", () => {
       `<({ id: 1, value: "the_option_name", color: "red" } | { id: 2, value: "the_option_name_2", color: "blue" })>`,
     ],
     [{ type: "number" }, `: number {`],
+    [
+      {
+        type: "rollup",
+        formula_type: "number",
+      },
+      `: number {`,
+    ],
+    [
+      {
+        type: "rollup",
+        formula_type: "number",
+      },
+      `parseFloat(`,
+    ],
   ])("%s => `%s`", (field, expected) => {
     expect(run(field)).toContain(expected);
   });

diff --git a/src/codegen/makeGetter.ts b/src/codegen/makeGetter.ts
@@ -38,7 +38,7 @@ function getReturnType(field: FieldDefinition, tables: Table[]): string {
       .join(" | ");
   }
 
-  if (field.type === "number") {
+  if (field.type === "number" || field.formula_type === "number") {
     return "number";
   }
 
@@ -49,7 +49,7 @@ function getBody(field: FieldDefinition, tables: Table[]): string {
   const rawType = makeFieldType(field);
   const query = `this.getField<${rawType}>("${field.name}")`;
 
-  if (field.type === "number") {
+  if (field.type === "number" || field.formula_type === "number") {
     return `return parseFloat(${query}.toString());`;
   }