Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adjust exposure times for locally varying sky background #77

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lpsinger
Copy link
Contributor

This is a quick and dirty implementation of adaptive exposure times that adjust for local variations in sky surface brightness.

Slew time constraints don't work with this yet.

Also there are a bunch of ad hoc command line arguments that need to be refactored.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Attention: Patch coverage is 2.81690% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 28.53%. Comparing base (f3f8784) to head (4466da1).
Report is 9 commits behind head on main.

❗ Current head 4466da1 differs from pull request most recent head 395cdc7. Consider uploading reports for the commit 395cdc7 to get more accurate results

Files Patch % Lines
...rado/scheduling/schedulers/continuous_time_slew.py 3.12% 62 Missing ⚠️
dorado/scheduling/scripts/main.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   28.78%   28.53%   -0.25%     
==========================================
  Files          35       35              
  Lines        1779     1801      +22     
==========================================
+ Hits          512      514       +2     
- Misses       1267     1287      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger force-pushed the sky-adjustable-exposure-time branch from 9602c4d to 55f228c Compare July 20, 2021 17:35
This is a quick and dirty implementation of adaptive exposure times
that adjust for local variations in sky surface brightness.

Slew time constraints don't work with this yet.

Also there are a bunch of ad hoc command line arguments that need
to be refactored.
@lpsinger lpsinger force-pushed the sky-adjustable-exposure-time branch from 55f228c to 24854a2 Compare July 22, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant