Wip/optimize parameters #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ood/Biquads into wip/optimize_parameters
…ls... this is a WIP
Signed-off-by: StoneyDSP <[email protected]>
|
Oh look, the CI/CD failed. No worries, the logs can help us determine the cause of failure so that we can reproduce, fix, create tests, and deploy a patch. Let's see what the logs say! SEGFAULT |
|
More seriously, strange that the build succeeded but it was pluginval which failed by SEGFAULTing. Suggests that perhaps the array index went out of bounds for some reason. That, or possibly a pointer to a non-valid object... well, whatever it is, at least we have some really helpful and informative information to begin our search with: SEGFAULT |
|
We'd probably have learned the cause of the issue whilst avoiding it, had we used the vector container template class and unique pointers. Let's try it with std lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?