-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add dss_line_iter() #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maciekszul , thanks for this.
I made a few minor comments.
Before we merge, I would like to add a unit test, and maybe also an illustrated example for the documentation.
Also see the CI has failed because of linting errors (you can run make pep
in the terminal to check this locally)
Do you have a data file we could use for this (it would need to be small in size to host it here). Otherwise I can try to generate some synthetic data.
Ok I went ahead and made some changes:
|
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 78.24% 78.75% +0.50%
==========================================
Files 20 21 +1
Lines 2211 2306 +95
==========================================
+ Hits 1730 1816 +86
- Misses 481 490 +9
Continue to review full report at Codecov.
|
Thanks! I had a quick look at it yesterday, but was a bit busy. |
I carved out 50 MB off of my data and will use it for testing. |
Awesome. I have a few fixes that I am just finishing, namely:
Will push in the next hour or so. I'll also update the branch in order to fix the CI (hopefully) |
plotting each iteration is vestigial to the initial development. Making it more compact will only help.
uploaded the small data packet |
- bump version - fixed doc - add `pytest --noplots` option
I started an example file. Ideally I would like it to show the difference between Does your file benefit from dss_line_iter explicitely? |
Precisely. For the user using MEEGkit, I would like the example to showcase the added value of dss_line_iter() compared to dss_line(). Therefore I would simply like to have an example for which |
I finished writing the example. What do you think? Also is it OK if I cite your name and email in the code? |
just pulled it and ran the tests. all looks pretty good to me.
of course. |
Cool, thanks @maciekszul |
Here's the iterative dss_line. Tried to conform the code to the convention you have used.