Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHubで全く動いていない #72

Closed
ncaq opened this issue Dec 7, 2022 · 1 comment · Fixed by #86
Closed

GitHubで全く動いていない #72

ncaq opened this issue Dec 7, 2022 · 1 comment · Fixed by #86
Labels
Priority: Critical Type: Bug Bug or Bug fixes

Comments

@ncaq
Copy link
Owner

ncaq commented Dec 7, 2022

仕様変更があった?
@ncaq
Copy link
Owner Author

ncaq commented Aug 5, 2023

  • titleにローカライズされた値が入らなくなってる
  • shadow DOMが使われている

ncaq added a commit that referenced this issue Aug 5, 2023
@ncaq
fix: GitHubのissueなどの基本表記に対応 closed #72
f0f4cf5 
[github/relative-time-element: Web component extensions to the standard <time> element.](https://github.com/github/relative-time-element)
が使われるようになって`title`が既にアメリカ限定ローカライズドされたものになってしまっていました。
`datetime`を使います。
ISO剥き出しの表記で良いかはよく分かりませんが、
少なくともUS表記よりはマシだと判断しました。
@ncaq ncaq linked a pull request Aug 5, 2023 that will close this issue
fix: GitHubのissueなどの基本表記に対応 closed #72 #86
Merged
@ncaq ncaq closed this as completed in #86 Aug 5, 2023
ncaq added a commit that referenced this issue Aug 5, 2023
@ncaq
Merge pull request #86 from ncaq/fix-github
3eb272c 
fix: GitHubのissueなどの基本表記に対応 closed #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Type: Bug Bug or Bug fixes
Projects
@ncaq TODO
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: GitHubのissueなどの基本表記に対応 closed #72 ncaq/goodbye-rfc-2822-date-time
1 participant
@ncaq