Support Ruby 2.5 & 2.6 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
force-pushed
the
waiting-for-dev/old_ruby
branch
2 times, most recently
from
380a0c7
to
938569a
Compare
Omnes was born as an extraction from [Solidus](https://github.com/solidusio/solidus) and it's used there to provide pub/sub support. Current Solidus still supports Ruby 2.5 & 2.6. We'll deprecate here as soon as they're deprecated on Solidus (which should happen in next major). An edge case that won't work on those versions is passing a serialized payload when publishing an unstructured event, as it'll require the kwargs keys to be Symbols. That's something not used on Solidus, so we don't make any changes to support it. For those cases, the workaround is publishing an event instance with the `#payload` method.
waiting-for-dev
force-pushed
the
waiting-for-dev/old_ruby
branch
from
938569a
to
a4acda4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnes was born as an extraction from
Solidus and it's used there to
provide pub/sub support. Current Solidus still supports Ruby 2.5 & 2.6.
We'll deprecate here as soon as they're deprecated on Solidus (which
should happen in next major).
An edge case that won't work on those versions is passing a serialized
payload when publishing an unstructured event, as it'll require the
kwargs keys to be Symbols. That's something not used on Solidus, so we
don't make any changes to support it. For those cases, the workaround is
publishing an event instance with the
#payloadmethod.