Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21 and #10 #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

#21 and #10 #22

wants to merge 5 commits into from

Conversation

XayOn
Copy link

@XayOn XayOn commented Jul 3, 2017

General cleanup and update. In the last 7 months aiohttp has grown quite a lot.

- Fixed PEP8
- Removed lots of duplicate code
- Updated to aiohttp 2.2
- Removed backwards compatibility pre-python3.5
  to use aiohttp's async with functionality and async def, much clearer syntax
- Using new aiohttp startup methods and signals
- Added TODO entries regarding login methods
- Removed old-and-unused debian files
- Fixed client style
- Moved documentation outside, deprecated websocket client library

I'm planning on adding individual websocket handling (by session or by a self-assigned id in authless use cases) and an aiohttp websocket client example soon. This PR lacks a lot of testing, does major changes and breaks things.

I've not added tests nor sphinx doc because I first wanted to see your opinion on the current PR, @neolynx

XayOn added 5 commits July 4, 2017 00:48
- Fixed PEP8
- Removed lots of duplicate code
- Updated to aiohttp 2.2
- Removed backwards compatibility pre-python3.5
  to use aiohttp's async with functionality
- Using new aiohttp startup methods and signals
- Added TODO entries regarding login methods
Also, it seems to be stalled.
Probably a branch or some other place for the debian/ folder
would be nice (after all, this would be just another python
library packaged)
@neolynx
Copy link
Owner

neolynx commented Sep 24, 2017

Hi XayOn,

that is a lot in pull req!
see my comments below:

  • Fixed PEP8
  • Removed lots of duplicate code

great!

  • Updated to aiohttp 2.2
  • Removed backwards compatibility pre-python3.5
    to use aiohttp's async with functionality and async def, much clearer syntax

not great, cirrina is still used pre-python3.5 and where aiohttp 2.2 is not available

  • Using new aiohttp startup methods and signals

I suppose this breaks compatibility with older aiohttp versions?

  • Added TODO entries regarding login methods

great!

  • Removed old-and-unused debian files

hmm. who said they were unused?

  • Fixed client style

great!

  • Moved documentation outside, deprecated websocket client library

backward compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants