Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Properly declare mixin node types as abstract #115

Merged
merged 1 commit into from
Sep 1, 2022
Merged

BUGFIX: Properly declare mixin node types as abstract #115

merged 1 commit into from
Sep 1, 2022

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Sep 1, 2022 •
edited by bwaidelich
Loading

Adds a abstract: true to all mixin node type definitions such that they can't be assigned individually

@bwaidelich bwaidelich changed the title TASK: add abstract true to all NodeType mixins BUGFIX: Properly declare mixin node types as abstract Sep 1, 2022
bwaidelich
bwaidelich approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you!
I just took the liberty to tweak commit message and description and to declare this as an actual BUGFIX

@bwaidelich bwaidelich merged commit e3a6841 into neos:master Sep 1, 2022
@crydotsnake crydotsnake deleted the task/mixin-abstract branch September 1, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crydotsnake @bwaidelich