BUGFIX: set unique form element identifier after node copy #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a form element with identifier propery is copied an exception is thrown. @see https://github.com/neos/form/blob/3a6122db36ad2c9e6f06316653a35c80ff47dee1/Classes/Core/Model/FormDefinition.php#L553 This changes adds a signal slot for \Neos\ContentRepository\Domain\Model\Node "afterNodeCopy" to make the form element identifier unique.
If you copy and insert a whole section which includes a form element with identifier the exception is still thrown. Therefore I use nodeAdded signal.
bwaidelich
reviewed
Jun 15, 2020
|
Ah one additional comment: I think this is a BUGFIX rather than a FEATURE (making it eligible for a patch level release) |
ger4003
changed the title
|
Thanks @bwaidelich for the review. I adjusted the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a form element with identifier propery is copied an exception is thrown.
@see https://github.com/neos/form/blob/3a6122db36ad2c9e6f06316653a35c80ff47dee1/Classes/Core/Model/FormDefinition.php#L553
This changes adds a signal slot for \Neos\ContentRepository\Domain\Model\Node
afterNodeCopyaddedNodeto make the form element identifier unique. This also works if a whole section having a form element with identifier is copied and inserted.Fixes #44