-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!!FEATURE: Reform i18n mechanism #3804
Open
grebaldi
wants to merge
38
commits into
9.0
Choose a base branch
from
task/centralize-i18n
base: 9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10aff6c
to
33fb626
Compare
33fb626
to
232e6a8
Compare
I like this, but wow it's also A LOT. Thanks for digging in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prelude to: #3773
refs: #3119
This PR reforms the UI's i18n mechanism by exposing a new function
translate
directly from the@neos-project/neos-ui-i18n
package.The function looks as follows:
And can be used like this:
The new mechanism is completely independent from registries. There's no longer a need for injecting the
I18nRegistry
to use translations, insteadtranslate
can be used directly.translate
will only work after the translations have been loaded during the bootstrapping process of@neos-project/neos-ui
. If it is used too early, it throws an exception.The function now also properly supports plural rules (via
Intl
Web API). ThaI18nRegistry
had only supported English plurals, but with broken rules (quantity=0 yielded singular instead of plural).Other changes included in this PR are:
@neos-project/neos-ui-i18n
is now TypeScript (savemanifest.js
)<I18n/>
-component was deprecatedI18nRegistry
is now properly documented, but was also deprecatedxliff.json
endpoint is now discovered via<link>
-tag, instead of initial data<link>
-tag is marked withprefetch
to slightly speed up the fetch request@neos-project/neos-ui-i18n
now has a comprehensive README.mdThis change is breaking, because translations may have relied on the broken plural rules. It is also breaking, because the signature for substitution parameters has changed slightly - although this should be non-breaking at runtime.