TASK: Compile artifacts for #3770 #3806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nodedata With this change the minimal required nodedata for each node in the rendered content is inserted as data attribute and not as inline script anymore. This improves performance as no extra function call is executed for each node. Additonally the reduction in rendered node attributes reduces the output filesize and again improves loading time. To prevent just-in-time loading of nodes all incomplete nodedata is requested after the guest frame has finished loading.
mhsdesign
commented
Jun 19, 2024
|
|
||
| const nodes = Object.assign( | ||
| {}, | ||
| legacyNodeData, // Merge legacy node data from the guest frame - remove with Neos 9.0 | ||
| nodesAlreadyPresentInStore, |
There was a problem hiding this comment.
as we merge we dont need to include them here imo ... they are already in the store
Co-authored-by: Marc Henry Schultz <[email protected]>
…r guest frame The content tree is loaded early and can load fully loaded nodes without being slower as the response time is the same. But this way we can skip lots of nodes from being loaded by the guest frame if they are already present in the store.
Sebobo
force-pushed
the
bugfix/remove-ui-script-tag
branch
from
ffd2b3a
to
bb857ea
Compare
Sebobo
force-pushed
the
bugfix/remove-ui-script-tag
branch
from
bb857ea
to
2dc814b
Compare
mhsdesign
force-pushed
the
bugfix/remove-ui-script-tag-compiled-artifacts
branch
from
01762de
to
e1998d3
Compare
mhsdesign
changed the title
…use the store previously it was cumbersome to collect all the `nodes` that are really on the page. But it should make no difference to do the lookup on a bigger set.
…ry endpoint that means `neosUiDefaultNodes` only needs one param. Technically we use a `Set` most times when we invoke the `q` endpoint but seb convinced me that this filtering doesnt hurt and is probably more sane :D
mhsdesign
force-pushed
the
bugfix/remove-ui-script-tag-compiled-artifacts
branch
from
d0f6ca2
to
6905d1a
Compare
mhsdesign
force-pushed
the
bugfix/remove-ui-script-tag-compiled-artifacts
branch
from
6905d1a
to
174c657
Compare
Sebobo
force-pushed
the
bugfix/remove-ui-script-tag
branch
from
2d46ef2
to
2401318
Compare
Sebobo
force-pushed
the
bugfix/remove-ui-script-tag
branch
from
2fd3193
to
f4520af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled build for testing of #3770