Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the first call to sync functions returning null #496

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fix the first call to sync functions returning null #496

merged 1 commit into from
Aug 26, 2021

Conversation

dmitmel
Copy link
Contributor

@dmitmel dmitmel commented Aug 24, 2021

This happens only right after instantiation of the plugin class, so calling any other asynchronous function seemingly fixes the problem.

Fixes #434.

This happens only right after instantiation of the plugin class, so
calling any other asynchronous function seemingly fixes the problem.

Fixes #434.
@justinmk
Copy link
Member

Nice, thank you! Does it look possible to add a test?

@dmitmel
Copy link
Contributor Author

dmitmel commented Aug 25, 2021

Dunno, I don't see any tests involving plugin classes or similar. Plus this bug is just a one-off typo to me.

@justinmk justinmk merged commit 318c1b5 into neovim:master Aug 26, 2021
@HiPhish
Copy link

HiPhish commented Aug 29, 2021

Sorry for bumping this PR, but what are the chances of getting a bugfix release soon? I need this for a plugin I am writing currently. It's not urgent, but I would rather avoid following HEAD for just one plugin.

@dmitmel
Copy link
Contributor Author

dmitmel commented Aug 29, 2021

As a workaround you can just post some dummy notification/request to the remote plugin when Vim loads. An empty method on the Python side is enough.

@HiPhish
Copy link

HiPhish commented Aug 29, 2021

I know, I already am doing that, so it's not a big deal, just ugly. (I am making a plugin which reads in the linter settings from pycodestyle and returns a dictionary, so I can set my Python file type settings automatically to match the linter settings)

@wookayin
Copy link
Member

wookayin commented Sep 6, 2023

A kind bump-up: pynvim v0.5.x (or any new version that includes this fix) is still unreleased.

@justinmk
Copy link
Member

I think @bfredl is required for that currently :)

@bfredl
Copy link
Member

bfredl commented Sep 11, 2023

What PyPI username should I add to the package?

@justinmk
Copy link
Member

"nvim" ? what was it before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First call to function returns null
5 participants