-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: vim.eval('v:true') should return python bool #506" #562
Conversation
The checks are failing even without the changes that I made (when the fork is identical to the current upstream) (https://github.com/samuelqp/pynvim/actions/runs/8304465825). |
Thanks for the PR! The tests are broken because they refer to a (internal) function that was removed in neovim/neovim@eb5d15e |
Thanks! Seems good now. |
One more ask: can you add a "Known issues" section after this section which explains this quirk? So that we don't get repeat reports of #506 |
Done |
assert h.legacy_vim.eval('1') == '1' | ||
assert h.legacy_vim.eval('v:null') is None | ||
assert h.legacy_vim.eval('v:true') is True | ||
assert h.legacy_vim.eval('v:false') is False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these tests still useful? Could change the expected values.
This reverts commit d549371. This fixes #523 and make UltiSnips usable. As mentioned by @jsr-p, the extra check is redundant and is not worth the slower performance.