Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0 #7

Open
wants to merge 111 commits into
base: master
Choose a base branch
from
Open

Release 4.0.0 #7

wants to merge 111 commits into from

Conversation

mazarijuraj
Copy link

Description

Release 4.0.0

Dependencies

  • netgrif/petri.svg: 1.1.0
  • netgrif/petriflow: 2.0.0
  • netgrif/petriflow.svg: 1.1.0
  • panzoom/panzoom: 4.5.1

How Has Been This Tested?

Ranorex tests

tuplle and others added 21 commits December 11, 2023 16:40
- commits from old repo
- refactor context menus and items
- fix resetting of select tool
- fix quick draw tool context menu
- change link of "Report a bug" button
- fix init name being deleted on type change, future refactor needed
[NAB-327] - Release 4.0.0
- add version of app to env
- fix quick draw tool context menu
- add context place and transition menu item to select all connected arcs
[NAB-327] - Release 4.0.0
- fix lint
- remove unused petriflow-info-dialog component
[NAB-327] - Release 4.0.0
- move hotkeys to canvas-listener-tool to enable zoom and move keys in simulation mode
- refactor canvas listeners and tools, remove usage of 'on click', 'on context menu' and 'on double click' events
[NAB-327] - Release 4.0.0
- add version to edit model dialog
- fix edit model save button disabled condition
- fix edit model context menu trying to save undefined model
[NAB-327] - Release 4.0.0

This PR has 12396 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +9261 -3135
Percentile : 100%

Total files changed: 348

Change summary by file extension:
.dockerignore : +189 -0
.editorconfig : +1 -1
.yaml : +163 -28
.md : +10 -53
.json : +136 -125
.tex : +2 -2
.properties : +3 -3
.ts : +8134 -2035
.html : +381 -538
.scss : +201 -142
.svg : +28 -206
.xml : +1 -0
.js : +9 -0
Dockerfile : +3 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

- update to Angular 17
- fix main app component styling
- set default input type to outline
- add abstract master-detail component
mazarijuraj and others added 30 commits July 2, 2024 08:29
- remove console.log
- increase click margin on canvas
- fix undefined error on startup
- add custom sorting to role and user refs which will make a secondary asc sort on ids
- add string collection data type to form builder field list
- add save point on breakpoint delete
- remove size from multiple element manipulation save
- fixes description and menu in action editor
- unify action editor links name
- add number of actions to action editor links
- remove double background on buttons
- add click on languages in i18n
- rework of setting allowed nets
- add shades on hover and sort the list
- add tags to dialogs
- fix tags nod being saved
- update dependencies
- add highlight and icon to actual history change in history
- change default sort of history, fix sorting in history by time
- fix bug with selection causing drag event to incorrectly move svg canvas
- add label to renderSideBySide select in history detail
- update version for build
- change margins and paddings in form builder field list
- move delete button to drag indicator to fix overflow hiding it
- fix canvas update functions ignoring new id of elements
- fix transition properties not update
- fix trigger tree not saving changes
- move tags to the end of edit dialog
- fix the file field and HTML field
- merge component fix
- add multichoice map autocomplete component
- small changes in spacing of field list in form builder
- fix problem with icon on enter/leave callbacks set inside Petriflow.SVG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants