Fixes: Netbox 4.0 breaking change #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce.role. This fixes adds logic to handle this change across Netbox versions.
radaelbroko
reviewed
Jun 25, 2024
|
@bortok Have you got a moment to review this one? |
|
@tardoe sorry for the delay, I'm traveling this month. The reason I didn't merge it right away is the need to bump netbox versions in the CI environment to test with 4.0. |
|
Hi @tardoe, I'm working on this. Could you please cancel this PR and make a new one with |
it has to be under the role setting if block to make sure the role is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames device.device_role to device.role. This fixes adds logic to handle this change across Netbox versions.