API-3570: Add /asset-urls endpoint
#4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhsanShihab
reviewed
Dec 13, 2023
| tokenGetParam | ||
| ); | ||
|
|
||
| const asset = new AssetUrlModel(assetData); |
There was a problem hiding this comment.
this should be either Library Image/Video/RawFile or Task Image/Video/RawFile asset. apiCaller will follow the redirection and fetch the data from the redirect URL. We need to detect what type of asset data is returned and return that object.
We should use the standard Location header for 302 http code in our api response. But we are using X-Resource-Location. then apiCaller can follow the redirection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://jira.sso.episerver.net/browse/API-3570
Related PRs:
Description
QA Steps