Add feature to view admin_audit log files #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a LogFileProvider class that identifies the available log files It checks if the admin_audit app is enabled, and fetches it's logfile path. Additionally, add ability for user to select the file they want to view. The "Download logs" button now downloads the currently selected log file. Tested by enabling/disabling admin_audit app, toggling "Log file" Signed-off-by: Lakshaya Tohan <[email protected]>
Signed-off-by: Lakshaya Tohan <[email protected]>
This was referenced May 3, 2023
This fixes an error: Optional parameter $levels declared before required parameter $logfile is implicitly treated as a required parameter Signed-off-by: Lakshaya Tohan <[email protected]>
|
I haven't had an opportunity to look closely at the code yet, but I like the idea. Some of this is based on #476, correct? This would certainly further address #318 / #129 w/o forcing the admin to use consolidated logging (see nextcloud/documentation#10604). P.S. Looks like one of your commits isn't signed so the tests can't run. A rebase to master probably a.good idea while you're at it. :-) |
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a LogFileProvider class that identifies the available log files It checks if the admin_audit app is enabled, and fetches it's logfile path.
Additionally, add ability for user to select the file they want to view. The "Download logs" button now downloads the currently selected log file.
Tested by enabling/disabling admin_audit app, toggling "Log file"