Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes for Groups (sharing to other users) #285

Closed
Tracked by #967
cradermacher opened this issue Dec 19, 2018 · 13 comments
Closed
Tracked by #967

Notes for Groups (sharing to other users) #285

cradermacher opened this issue Dec 19, 2018 · 13 comments
Labels
enhancement New feature or request

Comments

@cradermacher
Copy link

cradermacher commented Dec 19, 2018

Hi,

is it possible to use Notes with Groups?
All notes should be visible and editable for the Group

Regards
Christian


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@stefan-niedermann
Copy link
Member

The notes are all stored as files in the Notes-Folder. You should at least be able to share single files, though i do not know if one can place a shared file in his/her own Notes-folder so it can be used with the Notes-App.... ❓

@cradermacher
Copy link
Author

cradermacher commented Dec 19, 2018 via email

@korelstar
Copy link
Member

No, the default folder is always Notes. Another way would be to share a folder inside the notes folder to your group and let every user move that shared folder from their root directory to their notes folder. That's the way I'm using notes in order to have both: a shared folder and my own notes.

However, a valid enhancement of the app is to make this more easy. I thought we had already an issue for that, but I can't find it.

@korelstar korelstar added the enhancement New feature or request label Dec 19, 2018
@TruputiGalvotas
Copy link

I would be willing to take on this issue with some mentoring/guidance from nextcloud team.

@korelstar
Copy link
Member

Yay, that would be so great! I think we have two cases that should be realized: sharing a single note and sharing a category (i.e. a folder). Therefore, we have the following steps to be done:

Backend

  • add new attributes to lib/Db/Note.php which determine if the note is shared by the current user (and to which users) or if it is shared by another user (and by whom)
  • fill these attributes using the share API: https://docs.nextcloud.com/server/stable/developer_manual/api/OCP/Share/index.html
  • create and implement lib/Service/ShareService.php with methods for sharing/unsharing files or directories to other users (and, after sharing, move these to the other user's notes directory) using the share API
  • extend lib/Controller/NotesController.php with methods for sharing/unsharing notes using ShareService
  • create lib/Controller/CategoryController.php with methods for listing all categories and respective share info as well as sharing/unsharing categories using ShareService

Frontend

  • add new action for sharing/unsharing of notes and categories in app navigation
  • provide frontend for selecting users or groups (maybe there is a common design element that can be used, e.g. app sidebar).

Contribute

Please note that we are moving the frontend from AngularJS to VueJS (see #290). Therefore, please use the branch vue as base for development and create pull requests for that branch.

You can start with small steps and concentrate on a single step from the above list only, e.g. the changes in lib/Db/Note.php.

@korelstar
Copy link
Member

Please note also this related issue: #135 (Deletion of single shared note is not possible). That should be fixed by implementing the steps above.

We have also another issue about sharing, but there is the focus on making a note public available: #38. I think we should keep this independently.

@korelstar korelstar changed the title Notes for Groups Notes for Groups (sharing to other users) Mar 14, 2019
@cryptoquick
Copy link

This feature would be nice, because Nextcloud Text isn't letting users I share notes with edit the note in an editor or viewer, it just wants them to download the note.

@kirmaha
Copy link

kirmaha commented Nov 2, 2021

Interrested in this feature too, with read-only option on group sharing for whole categorie and sub-categories.

@kojid0
Copy link

kojid0 commented Jan 22, 2022

Since nextcloud deck has the option to share decks with other users, can't this part of code be included into nextcloud notes?

@korelstar
Copy link
Member

@kojid0 : I don't think so, because deck has a database backend and notes uses files. Therefore, sharing a note should be equivalent to sharing this file.

@robna
Copy link

robna commented Feb 8, 2023

...one year later...
may I ask: is this being implemented? Would make the Notes app much more useful if applied in a team context.
IMO, the criteria listed by @korelstar are still adequate for the purpose

@d4nyl0
Copy link

d4nyl0 commented May 5, 2023

Currently when you share a note or Notes folder (category), it goes to other users' Root.

I think it should be easier to move that object (single note or folder) directly under "Notes" of all other users.
When only one note is shared, if it belongs to a category, I'm not sure if it's cleaner to create that category for all other users or ignore it.

@juliushaertl
Copy link
Member

Sharing has been implemmented through file shares changing the target to the notes folder with #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants