Enh/preview links #5399
Merged
Enh/preview links #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a first quick code read and looks very reasonable from the implementation approach 💪 - will check in further detail once you request review |
max-nextcloud
force-pushed
the
enh/preview-links
branch
from
81a504a
to
f3161a2
Compare
max-nextcloud
force-pushed
the
enh/preview-links
branch
from
f3161a2
to
aa7ed7a
Compare
Use title attribute to mark previews in markdown. Introduce PreviewOptions component to add preview options for isolated links. If there's just one link in a paragraph you can turn it into a preview. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
They actually need to do different things due to the different structure. On the one hand we have the preview node with plain text content. And on the other hand a paragraph node with the text wrapped in a link mark. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/preview-links
branch
from
80ed416
to
544bfb6
Compare
They convert the node without changing the content resulting in an endless loop. Signed-off-by: Max <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
|
Pushed a small fix for eslint |
juliushaertl
approved these changes
Mar 7, 2024
|
Filed follow ups as #5442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots (wip)
Bildschirmaufzeichnung.vom.20.02.2024.12.23.34.webm
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)