-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(calendar): apply inert attribute according to isHeaderExpanded #3087
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -67,7 +67,7 @@ export function CalendarPicker(props: CalendarPickerProps) { | |||||
data-slot="picker-wrapper" | ||||||
// makes the browser ignore the element and its children when tabbing | ||||||
// @ts-ignore | ||||||
inert={isHeaderExpanded ? true : undefined} | ||||||
{...{inert: isHeaderExpanded ? "" : undefined}} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using - {...{inert: isHeaderExpanded ? "" : undefined}}
+ {...{inert: isHeaderExpanded ? null : undefined}} Committable suggestion
Suggested change
|
||||||
> | ||||||
<div | ||||||
ref={highlightRef} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using
null
instead of an empty string for theinert
attribute to ensure compatibility across all browsers.Committable suggestion