treewide: Refactor to per-project structure #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzleutgeb
force-pushed
the
metadata
branch
3 times, most recently
from
baf7347
to
7c5457d
Compare
lorenzleutgeb
force-pushed
the
metadata
branch
3 times, most recently
from
bdf5691
to
3864fa8
Compare
Merged
lorenzleutgeb
force-pushed
the
metadata
branch
4 times, most recently
from
20ef037
to
3e7c8ef
Compare
fricklerhandwerk
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74
Comments:
lib.nixfor definitions that are "generic". These started pollutingflake.nix. If you oppose creating such a "utility" file or want it to be renamed, I'll happily do so.README.mdshould not be a blocker for this PR. The changes I make are an improvement, and needed since the directory structure changes. We still have more to do, see Add contributor documentation #171. However, there are also PRs that depend on landing this, which are just as important, e.g. Static Site #169. I'd argue for merging this PR even if docs are not optimal, so that we can parallelize on Add contributor documentation #171 and Static Site #169.configs/all-configurations.nixwe now wire them together inprojects/*/default.nix.modules/all-modules.nixwe now wire most of them together inprojects/*/default.nix. There's one leftover module that I decided to directly add inflake.nix.nixdoccompatible comments inlib.nix, but it turns out thatalejandra(our code formatter) destroys them.