Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init atomic-server module #220

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Init atomic-server module #220

merged 2 commits into from
Aug 22, 2024

Conversation

Chickensoupwithrice
Copy link
Contributor

Building on work done in #170 (but not requiring it), this PR inits a module for atomic-server.
It's not ready for review but tested locally.

@fricklerhandwerk fricklerhandwerk changed the title Init atomoic-server module Init atomic-server module May 3, 2024
albertchae added a commit to albertchae/ngipkgs that referenced this pull request Aug 1, 2024
@albertchae
atomic-server: refactor to rebuild from github source
9fd1581 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on ngi-nix#220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
@albertchae albertchae mentioned this pull request Aug 1, 2024
Merged
albertchae added a commit to albertchae/ngipkgs that referenced this pull request Aug 1, 2024
@albertchae
atomic-server: refactor to rebuild from github source
c89d5ac 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on ngi-nix#220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
albertchae added a commit to albertchae/ngipkgs that referenced this pull request Aug 1, 2024
@albertchae
atomic-server: refactor to rebuild from github source
df71b00 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on ngi-nix#220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
@Chickensoupwithrice
Copy link
Contributor Author

Alright! After many many months, I think this may finally be ready for review.
We generate the .env file from settings, the systemd unit works on start up, and there is a test that passes.

The main thing to note, is that the .env file does end up in the /nix/store, though there aren't any secrets in the .env file, so I think that's okay? Alternatively we could get the user to provide the environmentFile as a secret that doesn't end up in the nix store.

@Chickensoupwithrice Chickensoupwithrice marked this pull request as ready for review August 13, 2024 03:51
@Chickensoupwithrice Chickensoupwithrice requested a review from a team as a code owner August 13, 2024 06:03
albertchae added a commit to albertchae/ngipkgs that referenced this pull request Aug 14, 2024
@albertchae
atomic-server: refactor to rebuild from github source
1558458 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on ngi-nix#220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
albertchae added a commit to albertchae/ngipkgs that referenced this pull request Aug 14, 2024
@albertchae
atomic-server: refactor to rebuild from github source
5c87a3a 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on ngi-nix#220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
fricklerhandwerk pushed a commit that referenced this pull request Aug 14, 2024
@albertchae @fricklerhandwerk
atomic-server: refactor to rebuild from github source
a70e44b 
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on #220

Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
`curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv`
and checking for the `assets_tmp` directory.
@Chickensoupwithrice Chickensoupwithrice force-pushed the aynish/atomic-server-module branch 2 times, most recently from c48d50c to e10e953 Compare August 20, 2024 16:55
@Chickensoupwithrice
Copy link
Contributor Author

Chickensoupwithrice commented Aug 20, 2024 •
edited
Loading

I'm not sure why the overview CI check is failing, or even what it does and how it's related to this PR.
I will run a nixfmt once I'm back at my computer to fix the pre-commit checks. I'll also re-squash this PR.

fricklerhandwerk
fricklerhandwerk approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Amazing perseverance getting this done despite the stretched out timeline.

@fricklerhandwerk fricklerhandwerk enabled auto-merge (rebase) August 22, 2024 09:24
@fricklerhandwerk fricklerhandwerk enabled auto-merge (rebase) August 22, 2024 09:25
@fricklerhandwerk fricklerhandwerk merged commit 25f7788 into ngi-nix:main Aug 22, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

@lorenzleutgeb lorenzleutgeb Awaiting requested review from lorenzleutgeb lorenzleutgeb was automatically assigned from ngi-nix/infra

@wegank wegank Awaiting requested review from wegank

@albertchae albertchae Awaiting requested review from albertchae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chickensoupwithrice @albertchae @fricklerhandwerk