Migrate nitrokey-firmware into monorepo #90
Draft
+3,759
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusf
commented
Nov 13, 2023
lorenzleutgeb
requested changes
Nov 14, 2023
mightyiam
force-pushed
the
nitrokey-firmware-alt
branch
from
5346e66
to
5c8409b
Compare
matusf
force-pushed
the
nitrokey-firmware-alt
branch
from
5c8409b
to
6185b81
Compare
augustebaum
force-pushed
the
nitrokey-firmware-alt
branch
from
6185b81
to
6258788
Compare
matusf
force-pushed
the
nitrokey-firmware-alt
branch
2 times, most recently
from
3798352
to
3f6fb52
Compare
Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Auguste Baum <[email protected]> Co-authored-by: Shahar "Dawn" Or <[email protected]>
Co-authored-by: Shahar "Dawn" Or <[email protected]> Co-authored-by: Matúš Ferech <[email protected]>
Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Auguste Baum <[email protected]>
because of unfree deps
mightyiam
force-pushed
the
nitrokey-firmware-alt
branch
from
3f6fb52
to
466cc60
Compare
|
I feel I made some good progress. Plan to continue tomorrow. |
|
Nothing to review yet. |
mightyiam
force-pushed
the
nitrokey-firmware-alt
branch
from
466cc60
to
94ed42e
Compare
Co-authored-by: Auguste Baum <[email protected]> Co-authored-by: Shahar "Dawn" Or <[email protected]>
mightyiam
force-pushed
the
nitrokey-firmware-alt
branch
from
94ed42e
to
8ec63d0
Compare
mightyiam
reviewed
Nov 28, 2023
| }: let | ||
| linuxSystem = "x86_64-linux"; |
There was a problem hiding this comment.
@lorenzleutgeb I'm not sure what to do with this. I'm quite sure I don't understand the overall structure of the flake and that's why I'm confused. I know it's documented with some comments, but I still don't get it. Perhaps I'll take another look. There's just too much passing of values around and I lose track.
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
Tracking issue: #12.