Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update smoothtrim: even window size #149

Merged
merged 2 commits into from
Nov 12, 2021
Merged

update smoothtrim: even window size #149

merged 2 commits into from
Nov 12, 2021

Conversation

mkuhn
Copy link
Collaborator

@mkuhn mkuhn commented Nov 12, 2021

Fixes #148

@mkuhn mkuhn requested a review from unode November 12, 2021 08:30
@unode
Explicitly document smoothtrim with even windows
84d94b0 
Also makes docs consistent as example listed 4 but showed window 3
@unode
Copy link
Member

unode commented Nov 12, 2021

Thanks @mkuhn !

I expanded your PR to be more explicit as "pad" was not a term we used in this context.

@unode unode merged commit 7ce04a4 into ngless-toolkit:master Nov 12, 2021
@mkuhn mkuhn deleted the mkuhn-patch-1 branch November 12, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unode unode Awaiting requested review from unode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for smoothtrim
2 participants
@mkuhn @unode