Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table rows have incorrect indention after grouping & ungrouping column #2284

Closed
mollykreis opened this issue Jul 17, 2024 · 2 comments · Fixed by #2301
Closed

Table rows have incorrect indention after grouping & ungrouping column #2284

mollykreis opened this issue Jul 17, 2024 · 2 comments · Fixed by #2301
Assignees
Labels
bug Something isn't working

Comments

@mollykreis
Copy link
Contributor

🐛 Bug Report

When the nimble-table has hierarchy enabled (parentIdFieldName set), grouping and then ungrouping a column causes the first cell to be incorrectly misaligned with the header.

This is due to a bug in TanStack that was discussed on the TanStack discord: https://discord.com/channels/719702312431386674/803508359378370600/1174456230790561902

Nothing, however, came from the discussion on discord other than confirmation that the behavior we're seeing is likely a bug in TanStack.

💻 Repro or Code Sample

🤔 Expected Behavior

Grouping and then ungrouping a column with hierarchy enabled should result in the initial cell indentation.

😯 Current Behavior

Grouping and then ungrouping a column with hierarchy enabled does not return cells to their initial indentation.

Grouping With Hierarchy Bug

💁 Possible Solution

File a bug to TanStack and potentially try to upstream a fix.

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@mollykreis mollykreis added bug Something isn't working triage New issue that needs to be reviewed labels Jul 17, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jul 23, 2024
@m-akinc
Copy link
Contributor

m-akinc commented Jul 23, 2024

May be fixed in 18.19.3?

@jattasNI
Copy link
Contributor

(which can be uptaken once #2289 is fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants