Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version of @tanstack/table-core pinned to avoid indentation issue #2289

Closed
m-akinc opened this issue Jul 18, 2024 · 0 comments · Fixed by #2301
Closed

Version of @tanstack/table-core pinned to avoid indentation issue #2289

m-akinc opened this issue Jul 18, 2024 · 0 comments · Fixed by #2301
Assignees
@mollykreis
Labels
tech debt

Comments

@m-akinc
Copy link
Contributor

m-akinc commented Jul 18, 2024

🧹 Tech Debt

In @tanstack/table-core version 8.19.3, a regression was introduced that causes grouped rows to be indented too much:

image

It is likely this submission caused the change. We should file a bug to Tanstack and see if we can deduce a workaround.
@m-akinc m-akinc added tech debt triage New issue that needs to be reviewed labels Jul 18, 2024
@m-akinc m-akinc mentioned this issue Jul 18, 2024
Merged
1 task
m-akinc added a commit that referenced this issue Jul 19, 2024
@m-akinc @rajsite
Update all dependencies and pin tanstack to avoid bug (#2288)
2ce3e24 
# Pull Request

## 🤨 Rationale

While trying to update to Angular 17, I discovered a build issue and a
table visual test regression due to incidental dependency updates.

## 👩‍💻 Implementation

- Regenerated `package-lock.json` from scratch
- Fixed property naming conflict in `RichTextEditor` due to change in
most recent release of `@tiptap/core` (see [global modification of
`HTMLElement`
interface](ueberdosis/tiptap@74bfdc5#diff-9b7c004a70a95a9e7b2b49f3761403a4abfe14fae1490e32c86306794017e27d))
- Pinned version of `@tanstack/table-core` to `8.19.2` because `8.19.3`
introduces a regression in table indentation under grouped rows:

![image](https://github.com/user-attachments/assets/bd5a778b-1114-444b-af71-b513cf6a41e4)
I filed tech debt #2289 to track the issue.


## 🧪 Testing

Existing tests

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jul 23, 2024
@jattasNI jattasNI mentioned this issue Jul 23, 2024
Closed
@mollykreis mollykreis self-assigned this Jul 23, 2024
@mollykreis mollykreis mentioned this issue Jul 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mollykreis mollykreis

Labels
tech debt
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update TanStack and fix a row indentation issue ni/nimble
2 participants
@m-akinc @mollykreis