-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where user can't type disabled option into combobox #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
approved these changes
Jul 19, 2024
m-akinc
commented
Jul 22, 2024
m-akinc
commented
Jul 22, 2024
jattasNI
reviewed
Jul 23, 2024
atmgrifter00
approved these changes
Jul 23, 2024
jattasNI
requested changes
Jul 24, 2024
jattasNI
approved these changes
Jul 25, 2024
@atmgrifter00 it looks like there were changes since your last review, could you give it another check JIC? |
jattasNI
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resetting my vote because I'd like to do one more round of testing based on the final implementation after the last bit of feedback is addressed
atmgrifter00
approved these changes
Jul 29, 2024
jattasNI
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #2252
π©βπ» Implementation
The
options
getter should not revert to returning all the options (i.e._options
) whenfilteredOptions
is empty. Doing so can lead to setting aselectedIndex
that points to an option that is filtered out or disabled.The expected behavior now is that a disabled option functions exactly like an enabled option, except that it cannot be clicked, cannot be focused in the dropdown, and appears dimmed. Like enabled options, t can be filtered to (if the input text matches it), and the user can set the control's value to it by typing it in fully.
π§ͺ Testing
Added new tests
β Checklist