Fix off-by-one

nikeee · May 29, 2023 · 53ba730 · 53ba730
1 parent b57efe1
commit 53ba730
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/service/hover.ts b/src/service/hover.ts
@@ -53,7 +53,7 @@ function getHoverContents(n: SyntaxNode): string | undefined {
 					if (n.symbol?.references) {
 						const nodeIdentifierRefs = n.symbol?.references;
 						const labelMentions = nodeIdentifierRefs.map(e => e.symbol?.members?.get("label")?.firstMention.parent as IdEqualsIdStatement | null | undefined);
-						for (let i = labelMentions.length; i > 0; i--) {
+						for (let i = labelMentions.length; i >= 0; i--) {
 							const s = labelMentions[i];
 							if (s?.rightId) {
 								return `(node) ${getIdentifierText(n)}: ${getIdentifierText(s.rightId)}`;

diff --git a/tests/providers/hover.spec.ts b/tests/providers/hover.spec.ts
@@ -153,4 +153,32 @@ describe("Hover Handling", () => {
 		let h = hoverOnCode(22);
 		expect(h.contents).toEqual("(node) c: xd");
 	});
+
+	/**
+	 * See https://github.com/nikeee/dot-language-support/issues/83
+	 */
+	test("should correctly show node labels on hover (other node)", () => {
+		const hoverOnCode = hoverSample(`digraph G {
+			vp [label="View Profile"];
+			vf [label="View Friends"];
+
+			vp -> vf;
+		}`);
+		let h = hoverOnCode(75);
+		expect(h.contents).toEqual("(node) vp: View Profile");
+	});
+
+	/**
+	 * See https://github.com/nikeee/dot-language-support/issues/83
+	 */
+	test("should correctly show node labels on hover (other node)", () => {
+		const hoverOnCode = hoverSample(`digraph G {
+			vp [label="View Profile"];
+			vf [label="View Friends"];
+
+			vp -> vf;
+		}`);
+		let h = hoverOnCode(81);
+		expect(h.contents).toEqual("(node) vf: View Friends");
+	});
 });