Update coding, contribution and moderation guides #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxscramper
force-pushed
the
code-guides
branch
from
45a3b69
to
8d14a9f
Compare
haxscramper
force-pushed
the
code-guides
branch
from
8d14a9f
to
cfb3e24
Compare
haxscramper
commented
Dec 12, 2021
There was a problem hiding this comment.
- Procedure argument alignment - I don't think it makes a lot of sense to
try and squash all arguments into as little space as possible, vertical
positioning makes it easier to read.
template newError*(
conf: ConfigRef,
wrongNode: PNode,
report: SemReport,
args: seq[PNode] = @[],
info: TLineInfo = wrongNode.info,
): untyped =and not
template newError*(conf: ConfigRef, wrongNode: PNode, report: SemReport,
args: seq[PNode] = @[], info: TLineInfo = wrongNode.info): untyped =
doc/intern.rst
Outdated
| `tests` the tests for |NimSkull|, including the language | ||
| specification under `tests/lang` | ||
| ============ =================================================== | ||
| - ``bin/``, ``build/`` - these directories are empty, but are used when Nim |
There was a problem hiding this comment.
Duplicate explanation in the readme and intern.rst, should only be contained in the intern.rst, and readme one was better formatted, so I moved it here.
There was a problem hiding this comment.
I kinda wish we just had markdown, or one source of truth, because I'm pretty sure we want to excerpt and not just link information.
There was a problem hiding this comment.
Suggested change
| - ``bin/``, ``build/`` - these directories are empty, but are used when Nim | |
| - ``bin/``, ``build/`` - these directories are empty, but are used when |NimSkull| |
saem
requested changes
Dec 12, 2021
haxscramper
force-pushed
the
code-guides
branch
from
cfb3e24
to
53b27b6
Compare
haxscramper
commented
Dec 18, 2021
haxscramper
force-pushed
the
code-guides
branch
3 times, most recently
from
930a69c
to
e3cb2f9
Compare
saem
reviewed
Dec 18, 2021
saem
reviewed
Dec 18, 2021
haxscramper
force-pushed
the
code-guides
branch
from
e3cb2f9
to
5a791f9
Compare
saem
requested changes
Dec 18, 2021
haxscramper
force-pushed
the
code-guides
branch
from
5a791f9
to
7a44083
Compare
saem
approved these changes
Dec 18, 2021
|
bors r+ |
|
Bors r+ |
|
Already running a review |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2021
127: readme.md: Add link to the contribution guide r=saem a=haxscramper Forgot to add link to the readme in the contribution guide pr - #125 Co-authored-by: haxscramper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, update contribution, moderation (GitHub moderation for now, will be expanded later) and style guides.