openssl: new wrapper targeting OpenSSL 3+ #1336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaviss
force-pushed
the
ssl3
branch
4 times, most recently
from
87c2dab
to
7996ea2
Compare
saem
reviewed
Jun 7, 2024
lib/pure/net.nim
Outdated
| ## Returns the certificate chain received by the peer we are connected to | ||
| ## through the OpenSSL connection represented by `sslHandle`. | ||
| ## The handshake must have been completed and the certificate chain must | ||
| ## have been verified successfully or else an empty sequence is returned. | ||
| ## The chain is ordered from leaf certificate to root certificate. | ||
| ## The chain is ordered from leaf certificat to root certificate. |
There was a problem hiding this comment.
Suggested change
| ## The chain is ordered from leaf certificat to root certificate. | |
| ## The chain is ordered from leaf certificate to root certificate. |
minor typo
alaviss
force-pushed
the
ssl3
branch
4 times, most recently
from
1a6ab16
to
927bee6
Compare
- Properly cleanup resources after each test - Terminate server on error: Previously the server would've kept running on error, which might cause later tests to fail - Server now read data using SSL_read instead of regular socket reads - Remove usage of threadpool as nothing here requires it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Fixes #1160
Notes for Reviewers
Details to be done after everything is working