fix fields with names containing backticks being inaccessible #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* identifier nodes resulting from gensyms are now tagged with a new node flag (`nfWasGensym`) * `originalName` only strips the `gensym` suffix from identifiers marked with the flag * the node flag is persistent, so that it stays on the node across tree copies
zerbina
added
bug
zerbina
changed the title
saem
approved these changes
Jul 27, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a regression where field names with backticks in them couldn't be
accessed with a field access.
Fixes #1379.
Details
node flag (
nfWasGensym)originalNameonly strips thegensymsuffix from identifiersmarked with the flag
copies
Looking for the full "`gensym" suffix wouldn't work, because it would
also trigger the stripping for user-created names containing the
suffix.