niminst: generate archive manifest after build #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
reviewed
Feb 2, 2022
| @@ -769,6 +770,51 @@ proc checkedShellExec(cmd: string) = | |||
| if exitCode != 0: | |||
| raise newExternalProgramError(exitCode) | |||
|
|
|||
| proc computeChecksum(file: string): string = | |||
| ## Calculate the SHA256 hash for `file`. | |||
| let p = startProcess( | |||
There was a problem hiding this comment.
Hah, I thought we'd have a standard library call for this, oh well.
saem
requested changes
Feb 2, 2022
tools/niminst/niminst.nim
Outdated
| stderr.write p.outputStream.readAll() | ||
| raise newExternalProgramError(exitCode) | ||
| else: | ||
| # OpenSSL produce an output in this format: |
There was a problem hiding this comment.
Suggested change
| # OpenSSL produce an output in this format: | |
| # OpenSSL produces output in this format: |
tools/niminst/niminst.nim
Outdated
| cpu: string ## The binary archive target CPU | ||
| of Source: | ||
| discard | ||
|
|
||
| proc archiveDist(c: var ConfigData) = |
There was a problem hiding this comment.
Suggested change
| proc archiveDist(c: var ConfigData) = | |
| proc createArchiveDist(c: var ConfigData) = |
If we only day it a few times then it's not worth saving the characters and it completely obviates the comment.
This allows tools to figure out what was created without doing guesswork on file name. Co-authored-by: Saem Ghani <[email protected]>
alaviss
force-pushed
the
niminst-manifest
branch
from
e5987ab
to
d0a5b85
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tools to figure out what was created without doing guesswork
on file name.
This will be used by the continuous delivery pipeline.