test and generate release binaries #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several changes packed in this:
- CI now build release compiler and tools, the same kind in a release
archive. This is to make sure that we test the exact binaries that we
ship.
- To help with this, new subcommand `all` is added to `koch` which
builds binaries the same way as a release build done by
`unixrelease` would.
- Source archive and release binaries will be packaged and uploaded to
artifacts. This allow for testing of these if required and will be
picked up and published via the continous delivery pipeline.
- A new test has been added: Verifying that the same release binaries
can be built from git and source archive. This test is done via
diffoscope, so in the event that it doesn't pass, a comprehensive
report will be uploaded to help trace the problem.
|
bors r+ (what happened buddy?) |
|
bors r+ (come on buddy_ |
bors bot
added a commit
that referenced
this pull request
Feb 5, 2022
226: test and generate release binaries r=saem a=alaviss
## Summary
This change facilitates the generation of source archive as well as
release archives in nimskull's CI. By integrating with main CI, we
test the binaries that will be released directly so they are
guaranteed to work.
## Details
There are several changes packed in this:
- CI now build release compiler and tools, the same kind in a release
archive. This is to make sure that we test the exact binaries that we
ship.
- To help with this, new subcommand `all` is added to `koch` which
builds binaries the same way as a release build done by
`unixrelease` would.
- Source archive and release binaries will be packaged and uploaded to
artifacts. This allow for testing of these if required and will be
picked up and published via the continous delivery pipeline.
- A new test has been added: Verifying that the same release binaries
can be built from git and source archive. This test is done via
diffoscope, so in the event that it doesn't pass, a comprehensive
report will be uploaded to help trace the problem.
Co-authored-by: Leorize <[email protected]>
|
Already running a review |
|
Timed out. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change facilitates the generation of source archive as well as
release archives in nimskull's CI. By integrating with main CI, we
test the binaries that will be released directly so they are
guaranteed to work.
Details
There are several changes packed in this:
CI now build release compiler and tools, the same kind in a release
archive. This is to make sure that we test the exact binaries that we
ship.
allis added tokochwhichbuilds binaries the same way as a release build done by
unixreleasewould.Source archive and release binaries will be packaged and uploaded to
artifacts. This allow for testing of these if required and will be
picked up and published via the continous delivery pipeline.
A new test has been added: Verifying that the same release binaries
can be built from git and source archive. This test is done via
diffoscope, so in the event that it doesn't pass, a comprehensive
report will be uploaded to help trace the problem.