cpp: remove cpp addr/deref handling in sem #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In semexprs there was a path that changed addr/deref handling for cpp. This is a layering violation and led to non-idempotent sem. Removal will result in many code gen issues for the cpp backend. This commit includes a number of changes to tests in order to ensure that CI still passes. Identifying tests modified due to cpp related failures with knownIssues. Additionally, a few small issues with testament were found and fixed: - tests weren't always skipped when they weren't in requested targets - megatest always ran, even if the c target wasn't specified
saem
force-pushed
the
remove-cpp-hack-in-sem
branch
from
f95dc8b
to
ba8f384
Compare
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
Build succeeded: |
zerbina
added a commit
to zerbina/nimskull
that referenced
this pull request
May 1, 2022
Fixes at least some of the code-gen issues introduced by nim-works#290. All previously deactived tests work again. Since temporaries are now also used in places where they previously weren't (for the C back-end), this is a breaking change.
zerbina
added a commit
to zerbina/nimskull
that referenced
this pull request
May 1, 2022
Fixes at least some of the code-gen issues introduced by nim-works#290. All previously deactived tests work again. Since temporaries are now also used in places where they previously weren't (for the C back-end), this is a breaking change.
bors bot
added a commit
that referenced
this pull request
May 1, 2022
294: cpp: fix `var` parameter regression r=saem a=zerbina Fixes at least some of the code-gen issues introduced by #290. All previously disabled tests work again. For more details, refer to ``tests/ccgbugs/tvar_param.nim``. Since temporaries are now also used in places where they previously weren't (for the C back-end), this is a breaking change. Co-authored-by: zerbina <[email protected]>
zerbina
modified the milestones:
VM backend refactoring,
Semantic analysis phase refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In semexprs there was a path that changed addr/deref handling for cpp.
This is a layering violation and led to non-idempotent sem. Removal
will result in many code gen issues for the cpp backend.
This commit includes a number of changes to tests in order to ensure
that CI still passes. Identifying tests modified due to cpp related
failures with knownIssues.
Additionally, a few small issues with testament were found and fixed:
Notes for Reviewers
Relates to the discussion here: #289
It's not fully disabling or removing cpp features, but at least we can make honest fixes
instead of hacks.