internal: don't use VM callback for addFloatRoundtrip
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function doesn't need to be overriden with a VM callback implementation in order to work in the VM. In addition, the usage of a callback was problematic in this case, as the callback has no way to know if the input is a `float32` or `float64` and always treated it as the latter
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function doesn't need to be overridden with a VM callback
implementation in order to work in the VM. In addition, the usage of
a callback was problematic in this case, as the callback has no way
to know if the input is a
float32orfloat64and always treatedit as the latter
Fixes the
tfloats.nimtest in the data layout PR