tuple unpacking in const/let/var disallows pragmas #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
force-pushed
the
saem-cleanup-semvarorlet
branch
2 times, most recently
from
357bb3d
to
ce6bdc4
Compare
`let (a {.compileTime.}, b) = (1, 2)` and most other pragmas led to nil
pointer exceptions in the compiler, didn't make sense as the example, or
in some other way posed a significant issue. For now they've been made
illegal.
Highlevel Change:
- the compiler will show an error message if attempted
- there tests for these errors
- the manual.rst has a note added to the tuple unpacking section
Other Changes/Notes:
- add more compiler trace points, as needed for debugging
- added trace points for PNode -> TCandidate procs
- `semVarOrLet` is much longer and a bit more linear
- minor formatting touch ups here and there
Future work:
- `semVarOrLet` and `semConst` should likely get merged
- need to take more advantage of nkError to reduce code
Random Lessons:
- the compiler is already using lowerings in sem due to ambiguities
- assignment overloads don't work in const/var/let
- tuple unpacking potentially evaluates the rhs multiple times
saem
force-pushed
the
saem-cleanup-semvarorlet
branch
from
ce6bdc4
to
1d7def2
Compare
saem
changed the title
|
bors r+ |
|
👎 Rejected by PR status |
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jun 20, 2022
357: compiler: use nkError in sem for import export r=saem a=saem ## Summary - semExportExceptStmt is reworked like semVarOrLet - removed deadcode in importer `importForwarded` - more of importer is now nkError aware `semVarOrLet` refactor: #316 Co-authored-by: Saem Ghani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tuple unpacking in const/let/var disallows pragmas
let (a {.compileTime.}, b) = (1, 2)and most other pragmas led to nilpointer exceptions in the compiler, didn't make sense as the example, or
in some other way posed a significant issue. For now they've been made
illegal.
Details
Primary Changes
Other Changes/Notes:
semVarOrLetis much longer and a bit more linearFuture work:
semVarOrLetandsemConstshould likely get mergedRandom Lessons: