internal: remove sons from leaf nodes empty/none #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerbina
reviewed
Jul 31, 2022
There was a problem hiding this comment.
Left a small suggestion.
As an aside, I think it'd make future tracking down of changes (e.g. via git blame) easier if the refactorings unrelated to the main topic of the PR (single-line statements to multi-line, for it in n instead of for i in 0..<n.len, etc) are done in a separate PR. I don't consider this to be a blocker however.
saem
force-pushed
the
saem-pnode-enforce-no-sons-on-leaves
branch
2 times, most recently
from
e40ddb4
to
1c5f79c
Compare
- pulls nkEmpty and nkNone into a branch without sons
- various small fixes to get bootstrap working
- no tests failed, so that's a good{?} sign
saem
force-pushed
the
saem-pnode-enforce-no-sons-on-leaves
branch
from
1c5f79c
to
0f14ce0
Compare
|
Bots r+ |
Clyybber
reviewed
Aug 2, 2022
Comment on lines
+433
to
+436
| if father.len == 0: | ||
| return | ||
| for i in idx..<father.len - 1: | ||
| father[i] = father[i + 1] |
There was a problem hiding this comment.
Preexisting, but that if check is unneccessary, as the loop body will not execute if father.len is zero.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2022
392: internal: remove sons from leaf nodes empty/none r=saem a=saem
## Summary
- pulls nkEmpty and nkNone into a branch without sons
- ensures more correctness by design
## Details
- various small fixes to get bootstrap working
- no tests failed, so that's a good{?} sign
Co-authored-by: Saem Ghani <[email protected]>
|
Timed out. |
|
Bots r+ |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details