cpp: remove this pragma, breaks codegen #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the this pragma, but codegen is now broken: - codegen no longer renames parameters that happen to be called `this` - can't find a reasonable causal chain that explains why - disabled tests that fail on the cpp backend in the meantime Added benefit: - removed the `nfExprCall` flag - remove the `sfIsSelf` const/flag - CI should run faster and less cruft in dispatch It also became clear that `semIndirectOp` and call patterns around it need a complete rewrite. The results should be simplified dispatch.
|
Bots r+ |
2 similar comments
|
Bots r+ |
|
Bots r+ |
|
bors r+ |
|
Build succeeded: |
haxscramper
added
the
simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the this pragma, but codegen is now broken:
thisAdded benefit:
nfExprCallflagsfIsSelfconst/flagIt also became clear that
semIndirectOpand call patterns around itneed a complete rewrite. The results should be simplified dispatch.