internal: add missing reports and clean-up #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haxscramper can you take a quick look at the I don't think there is an issue, but just in case I didn't consider something. |
|
No, no problems with |
added missing reports for the parser: - template missing end close - invalid expression - invalid filter Misc: - created an enum for compiler verbosity - removed `rparName`, doesn't seem used at all - formatting fixes
saem
force-pushed
the
saem-fix-missing-reports
branch
from
9e6f349
to
0fdcf09
Compare
|
hah, left some asserts in there. |
Thanks for looking it over -- yeah that was my conclusion too. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
added missing reports for the parser:
Misc:
rparName, doesn't seem used at all