split out and expose package recipe #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
reviewed
May 15, 2024
this allows building underlying derivations with other inputs:
nix-repl> :l https://github.com/nixos/nixpkgs/tarball/nixpkgs-unstable
nix-repl> :l https://github.com/nix-community/nixdoc/tarball/master
nix-repl> pkgs.callPackage recipes.nixdoc {}
fricklerhandwerk
force-pushed
the
split-package
branch
from
c5662a2
to
c60697b
Compare
fricklerhandwerk
changed the title
infinisil
requested changes
May 24, 2024
|
This seems fine to me, even if not very standard. If you could add a small changelog entry for this that would be great, since this is essentially a new part of the API. Seems good to merge with the above addressed and the conflict fixed. |
Co-authored-by: Silvan Mosberger <[email protected]>
infinisil
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows building underlying derivations with other inputs: