plugins/guess-indent: init #1918
Conversation
plugins/utils/guess-indent.nix
Outdated
| }: | ||
| helpers.neovim-plugin.mkNeovimPlugin config { |
There was a problem hiding this comment.
| }: | |
| helpers.neovim-plugin.mkNeovimPlugin config { | |
| }: | |
| with lib; | |
| helpers.neovim-plugin.mkNeovimPlugin config { |
Even though this is not recommended in nixpkgs, we adopted this convention across the nixvim codebase.
There was a problem hiding this comment.
Should we reconsider this? Perhaps we could inherit (lib) X Y Z instead?
At least in new files - I'm not proposing we go around changing this in existing code for the sake of it.
There was a problem hiding this comment.
+1 on not using with
nixpkgs has a tendency on getting rid of it, at least partially (NixOS/nixpkgs#292468) and best practices also suggests that inherit should be preferred.
|
Thanks for the blazingly fast review! Also, I didn't run the testing suite (because it is just too heavy for my machine), so I didn't notice the |
That's reasonable, however note that in the devshell ( |
|
Out of curiosity: does this plugin have the same goal as tpope's slueth? How does it differ? |
Yes, it does. However it's written for nvim specifically. Here you can see the comparison: https://github.com/NMAC427/guess-indent.nvim/tree/6cd61f7a600bb756e558627cd2e740302c58e32d?tab=readme-ov-file#alternatives |
|
Do the CI checks normally take 20+ hours? 😅 That's so dumb that there isn't any caching or selective testing involved. The reviews and bugfixing were done in <30 minutes, and the tests are literally still running... |
The tests are actually finished (all passed) but something has gone wrong reporting some of them to GitHub (because there's over 1000 and we have hit a rate limit) |
Still, they have finished just 4 hours ago. That's 16 hours.
Yeah, I'm not surprised - maybe they should just report as 1 huge test, or a small number of categorized tests. By the way, is there anything else to do with this PR or is it ready to merge (and GitHub is preventing that because of the unfinished tests)? |
Could you rebase on main and squash to two commits (one adding you to maintainers, and another adding the plugin)? Only the The main thing is having at least one approving review. I'll try and review properly shortly!
We had one huge test until very recently, which buildbot couldn't handle as the memory requirements ended up being extreme. We'll probably end up with a compromise where we have maybe 20 grouped tests, but we're still experimenting with finding a good balance. There's also effort upstream in buildbot to improve how many tests get reported. |
I think I did what I was supposed to... I had to learn about rebasing, because this is my first serious PR to a big project |
This comment was marked as outdated.
This comment was marked as outdated.
Looks perfect, thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
MattSturgeon
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Added https://github.com/NMAC427/guess-indent.nvim