Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md : add a FAQ about memory release #1933

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented Feb 10, 2020

Refer to #1924 .

I think it is a very import case that we should add documents about it in README.md.
For me, it is helpful if I can find the case in README.md instead of searching issues.

Also, if we find a perfect solution in #1924 or other place, please update the README.md.

@coveralls
Copy link

coveralls commented Feb 10, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 2ccdfeb on dota17:dota17-FAQ into 973c52d on nlohmann:develop.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dota17 dota17 requested a review from nlohmann February 20, 2020 01:27
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the word "prasering".

README.md Outdated Show resolved Hide resolved
@dota17
Copy link
Contributor Author

dota17 commented Mar 16, 2020

Done.

@nlohmann nlohmann self-assigned this Mar 19, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Mar 19, 2020
@nlohmann nlohmann merged commit 19843b0 into nlohmann:develop Mar 19, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


@dota17 dota17 deleted the dota17-FAQ branch March 24, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants