Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly select "Release" build for Travis #2375

Merged
merged 4 commits into from
Mar 25, 2021

Conversation

karzhenkov
Copy link
Contributor

@karzhenkov karzhenkov commented Aug 25, 2020

Ninja doesn't support multiple build configurations. The option --config Release has no effect when cmake --build is called. Essentially, all testing was performed for "Debug" configuration, which is the default. Maybe it doesn't really matter, but it's misleading. The proper way to select build configuration here is through CMAKE_BUILD_TYPE.

@coveralls
Copy link

coveralls commented Aug 25, 2020

Coverage Status

Coverage remained the same at 99.982% when pulling bf75a1b on karzhenkov:fix-travis-release into 6f55193 on nlohmann:develop.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 4, 2020
@nlohmann nlohmann removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 5, 2020
@karzhenkov
Copy link
Contributor Author

The coverage test requires the use of the "Debug" configuration. From the GCC documentation:

if you want to prove that every single line in your program was executed, you should not compile with optimization at the same time

@karzhenkov karzhenkov marked this pull request as ready for review December 26, 2020 19:15
@nlohmann
Copy link
Owner

@karzhenkov Can you please update to the latest develop branch? I changed a lot of issues in the CI and moved some checks from Travis to GitHub Actions. Maybe the changes of this PR may need to be applied in cmake/ci.cmake.

# Conflicts:
#	.travis.yml
@karzhenkov
Copy link
Contributor Author

I think there is nothing here that we can apply to cmake\ci. cmake.

.travis.yml Show resolved Hide resolved
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Mar 25, 2021
@nlohmann nlohmann added this to the Release 3.9.2 milestone Mar 25, 2021
@nlohmann nlohmann merged commit 4a344e1 into nlohmann:develop Mar 25, 2021
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants