Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranged insert test section is added in unit-ordered_json.cpp #2512

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Ranged insert test section is added in unit-ordered_json.cpp #2512

merged 2 commits into from
Dec 11, 2020

Conversation

YarikTH
Copy link
Contributor

@YarikTH YarikTH commented Dec 7, 2020

Fix proposal for "#2490 Missing "void insert( InputIt first, InputIt last );" overload in nlohmann::ordered_map"
This PR is in Work In Progress state

Todo:

  • Add missing test case that fails
  • Add proposed method implementation
  • Make sure test is passed
  • PR is done and ready for approval

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@YarikTH YarikTH marked this pull request as draft December 7, 2020 16:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 972c15f on YarikTH:issue2490 into d8d8cbf on nlohmann:develop.

@YarikTH YarikTH changed the title [WIP] Ranged insert test section is added in unit-ordered_json.cpp Ranged insert test section is added in unit-ordered_json.cpp Dec 8, 2020
@YarikTH YarikTH marked this pull request as ready for review December 8, 2020 07:50
@YarikTH
Copy link
Contributor Author

YarikTH commented Dec 8, 2020

Tests on macOS 10.13 are failed, but it doesn't connect with this PR. Something strange with the container itself.
I can't fix it due to "one fix - one PR" rule. And I have no idea how to fix container errors anyway.

@YarikTH
Copy link
Contributor Author

YarikTH commented Dec 8, 2020

Maybe this PR need additional try_compile test for exactly what I tried initially - explicitly instantiated nlohmann::json and nlohmann::ordered_json because lack of method was discovered exactly this way. It allows finding other such problems in the future. But I don't know where to place such a test. I think It doesn't match a normal test suite. Any ideas?

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit d9e2b19 into nlohmann:develop Dec 11, 2020
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants