Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use without the dependency to file io and streams to use in intel sgx enclaves #2729

Merged
merged 6 commits into from
Jun 26, 2021

Conversation

theShmoo
Copy link
Contributor

includes some macros to be defined for using without file io.

includes some macros to be defined for using without file io.
@coveralls
Copy link

coveralls commented Apr 21, 2021

Coverage Status

Coverage remained the same at 99.982% when pulling 572343b on theShmoo:without-io into 18a5f4c on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make amalgamate to make sure the single header is properly generated. The CI currently fails because this.

@theShmoo theShmoo changed the title Fixes #2728 Possibility to use without the dependency to file io and streams to use in intel sgx enclaves May 13, 2021
@nlohmann
Copy link
Owner

Sorry for the inactivity. I have one question left: you write in #2728 that the headers for I/O do not exist. But in your change you seem not to exclude any headers if JSON_NO_IO is defined.

@theShmoo
Copy link
Contributor Author

Ah that is true!
The headers exist in Intels SGX implementation of the standard library. But they are empty:

for example in iostream: https://github.com/intel/linux-sgx/blob/master/sdk/tlibcxx/include/iostream

Should I remove the includes so that it also usable for other applications?

@nlohmann
Copy link
Owner

Yes, please. The use case may be still quite special, but at lease it would not assume include included headers are empty. I could imagine that that flag may be usable for some if they want to reduce compile times if they do not use I/O in their project.

@theShmoo
Copy link
Contributor Author

theShmoo commented Jun 1, 2021

Does the build pipeline fail because of me or is this an error in the pipeline?

@nlohmann
Copy link
Owner

nlohmann commented Jun 7, 2021

This seems to be an issue in the pipeline. I need to investigate.

@nlohmann
Copy link
Owner

Please update the branch - I just merged #2817 to fix the CI.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@theShmoo
Copy link
Contributor Author

Thank you very much for your support and your review!

@nlohmann nlohmann merged commit 6471a63 into nlohmann:develop Jun 26, 2021
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to use without the dependency to file io and streams to use in intel sgx enclaves
3 participants